search

kosukeimai / CBPS

R package: CBPS
27 stars 10 forks source link

high-dimensional CBPS #2

Closed kosukeimai closed 7 years ago

kosukeimai commented 7 years ago

@christianfong Can you see if this looks good to you? Thanks. @psdsam created a branch from the cbiv branch and so I'm requesting a merge into that branch rather than the master branch

kosukeimai commented 7 years ago

@psdsam There is one more Note concerning your change (see this). Would you mind fixing it? Thanks.

psdsam commented 7 years ago

Hi Kosuke,

I see. My code requires the package glmnet. I am not sure where to include the package in this process though. Do you have any idea?

Thank you,

Best,

Sida

On Wed, Apr 26, 2017 at 9:09 AM, Kosuke Imai notifications@github.com wrote:

@psdsam https://github.com/psdsam There is one more Note concerning your change (see this https://travis-ci.org/kosukeimai/CBPS/builds/225998368). Would you mind fixing it? Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kosukeimai/CBPS/pull/2#issuecomment-297401811, or mute the thread https://github.com/notifications/unsubscribe-auth/AMIIziNxkMsidOrs0Zi7vxykNJazXeXOks5rz0H0gaJpZM4NIzNk .

kosukeimai commented 7 years ago

Try adding the package to DESCRIPTION file and also import the functions you are using in NAMESPACE

psdsam commented 7 years ago

I think it has been fixed.

On Wed, Apr 26, 2017 at 9:18 AM, Kosuke Imai notifications@github.com wrote:

Try adding the package to DESCRIPTION file and also import the functions you are using in NAMESPACE

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kosukeimai/CBPS/pull/2#issuecomment-297404720, or mute the thread https://github.com/notifications/unsubscribe-auth/AMIIzhRQg6QRza0KA0d6o5RqLKkFoGCbks5rz0QugaJpZM4NIzNk .