search

kosukeimai / CBPS

R package: CBPS
27 stars 10 forks source link

cbiv #3

Closed kosukeimai closed 7 years ago

kosukeimai commented 7 years ago

@christianfong Is this branch ready to be merged into the master branch?

christianfong commented 7 years ago

@kosukeimai It's up to you. If you're confident in putting this in the next update for CBPS, I think we should go ahead and merge them. But if you think the empirical application that Scott is working on might be the result of some serious flaw in the code, then perhaps we should hold off. But on my end everything is ready (except an example for the documentation, which I will make before our next push to CRAN).

kosukeimai commented 7 years ago

Ok. Let's wait then