search

kosukeimai / CBPS

R package: CBPS
27 stars 10 forks source link

ATT for hdCBPS #5

Closed psdsam closed 6 years ago

psdsam commented 7 years ago

Adding ATT into hdCBPS

christianfong commented 7 years ago

I'm out of the loop on what's going on here. What does this function do, and why should we put it in the CBIV branch if its modifying CBPSBinary?

ratkovic commented 7 years ago

Christian

Cleaned this up--moving from master to a branch.

Variance for CBPS binary.

Marc

Marc Ratkovic Assistant Professor Department of Politics Office: Corwin Hall 035 Princeton University Email: ratkovic@princeton.edu Princeton, NJ 08544-1012 http://www.princeton.edu/~ratkovic

From: christianfong [notifications@github.com] Sent: Friday, June 23, 2017 1:59 AM To: kosukeimai/CBPS Cc: Subscribed Subject: Re: [kosukeimai/CBPS] ATT for hdCBPS (#5)

I'm out of the loop on what's going on here. What does this function do, and why should we put it in the CBIV branch if its modifying CBPSBinary?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/kosukeimai/CBPS/pull/5#issuecomment-310579379, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AI21oOlG72ph9WocDmpHjY9qgZlPbR8Rks5sG1RZgaJpZM4ODFhC.

kosukeimai commented 7 years ago

@ratkovic I think it would be helpful if you could explain to @christianfong exactly what you've done and update the documentation too. Thanks.

kosukeimai commented 7 years ago

Also, @christianfong This merge is requested by @psdsam who wants to add high dimensional CBPS to the cbiv branch, which for whatever reason contains the initial changes regarding hdCBPS. It should have been a separate branch but oh well...

christianfong commented 7 years ago

@ratkovic : I have several proposed changes to the binary variance function. I will send details to you via email.

@psdsam: You can put your changes in CBIV if you want (especially since it doesn't affect the CBIV files), but I see that there is a request to merge CBIV into master. CBIV is not ready to merge into master, and will not be ready for some time. If you want to merge and submit to CRAN ahead of CBIV, you will need your own branch.