Closed sysilviakim closed 5 years ago
Thanks, Sylvia! This is a good catch - an edge case that as you mention will come up a lot with dynamic merges. We've added handling for this case in the EM in the newest commit, and will make this part of the newest submit to CRAN.
Hello all,
Thank you for the amazing package again.
fastLink
works very well with moderate to large sized datasets---when faced with extremely small sample, it sometimes breaks down. For instance, with the commit on Sep 5, 2018 on gamma functions, the following works:The following still gives an indexing error (no underlying true matches):
and in case that there happens to be only single observations in both
dfA
anddfB
,ncol(patterns) - 1
is not correctly recognized from functionemlinkMARmov
(line 7), and the following also breaks:As for the last case, it works when
dfA = dfA[1, ]
anddfB = dfA[c(1, 2), ]
, so I really don't know what's the issue here---it'll be great if there's a warning and an empty output with the same structure instead of failing, since the last setup doesn't make sense for a probabilistic matching anyway. Such small samples sometimes come up in a dynamic setting.Sincerely, Silvia