Closed mdtrinh closed 5 years ago
@mdtrinh There appear to be some conflicts. Would you mind resolving them?
@mdtrinh Thanks. Can you go ahead and resolve the conflicts for R/amelidiate.R
? Just wanted to make sure that I don't mess things up. Thanks.
Will do. I will update you as soon as I am done resolving all the conflicts so you can initiate the merge
On Thu, Sep 5, 2019 at 1:28 PM Kosuke Imai notifications@github.com wrote:
@mdtrinh https://github.com/mdtrinh Thanks. Can you go ahead and resolve the conflicts for R/amelidiate.R? Just wanted to make sure that I don't mess things up. Thanks.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kosukeimai/mediation/pull/18?email_source=notifications&email_token=ACWMFDN34ZPUUXBEKULWOF3QIE6VTA5CNFSM4INVI2G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ABKBI#issuecomment-528487685, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWMFDIHIVIQ6BFZKAWM3P3QIE6VTANCNFSM4INVI2GQ .
-- Minh Trinh
60 Wadsworth St Apt 4D Cambridge, MA 02142
@mdtrinh Thanks. Can you go ahead and resolve the conflicts for
R/amelidiate.R
? Just wanted to make sure that I don't mess things up. Thanks.
I just resolved the conflicts in amelidiate.R and re-run the checks just to make sure. Everything looks good to go now
@mdtrinh Thanks!
Added a new function
mediate_tsls()
to conduct mediation analysis using a 2SLS estimator (this implements what we briefly discuss in an appendix of the APSR paper, i.e. estimating AMCE with an instrument when linearity holds).Improved how the nonparametric bootstrap for
mediate()
is done internally by allowing for simple parallelization through theboot
package and fast re-fitting oflm
andglm
models using thespeedglm
packageNow using Roxygen to automatically generate documentation.
Reorganized the code by creating new internal functions. Replaced some other internal functions with canned functions from base R or other packages
Fixed a number of bugs.