search

kota65535 / github-openvpn-connect-action

GitHub Action for connecting to OpenVPN server.
MIT License
85 stars 54 forks source link

Set mode option #25

Closed jaap3 closed 1 year ago

jaap3 commented 1 year ago

Fixes issue #24

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kota65535 commented 1 year ago

@jaap3 Thank you for contributing! Now CI is failing, but maybe it is because npm run build is not run yet and dist/index.js is not committed. It should be automatically run as pre-commit hook thanks to husky.

jaap3 commented 1 year ago

Ah, I used the GitHub editor in the browser, I don't think commit hooks run that way. Thanks for looking into this.

kota65535 commented 1 year ago

@jaap3 Do you want to continue with this PR? If not, I'm going to close this now and merge #26 instead.

jaap3 commented 1 year ago

Please merge the other one, thanks!