search

kotcrab / ghidra-allegrex

Ghidra processor module adding support for the Allegrex CPU (PSP)
Apache License 2.0
88 stars 8 forks source link

Use Ghidra's Gradle scripts for packaging the extension #35

Closed rndtrash closed 3 months ago

rndtrash commented 10 months ago

Ghidra 10.4 didn't like the .zip from releases, and since I use a Flatpak version of Ghidra, I can't modify the installation that easily, so I changed the Gradle script to use Ghidra's tasks for packaging, and now it makes packages that can be installed in Ghidra (./gradlew buildExtension). Though I'm not sure if I didn't miss anything important, it's my first time writing Gradle scripts and my first time using this extension :P

image image ghidra_10.4_FLATPAK_20231104_ghidra-allegrex.zip

Nemoumbra commented 10 months ago

Oh, so the problem is with a specific install of Ghidra 10.4 that doesn't let you access its ghidra_10.4_PUBLIC\Ghidra\Processors dir?

rndtrash commented 10 months ago

Well, more like the whole Ghidra folder is read-only.

kotcrab commented 10 months ago

Sorry but this can't be merged in this form as you've removed important stuff for the development and CI workflows. I have this partially done in my other extension I'm working on but CI is still on the to do list.

This covers issue #8.

rndtrash commented 10 months ago

I can fix the CI workflow if you want, seems as easy as replacing ghidraInstallThenPackage with buildExtension and build/dist with just the dist.

About the important development stuff, what's missing?

kotcrab commented 10 months ago

The ghidraInstall* tasks are important for development, they are described in the README (which will also need updating). Don't want to discourage you but I'll want to have this unified with my other extension repo so my plan is to do it there then port changes here. Though it's good we have some way for building it the standard way for people for need it so this can stay open.

rndtrash commented 10 months ago

It's alright, I just wanted to build this extension, no pressure 🙂👍🏻

kotcrab commented 3 months ago

I've done the required changes for this on the master branch so closing this PR.