search

kotelnik / plasma-applet-active-window-control

Plasma 5 applet for controlling currently active window.
GNU General Public License v2.0
119 stars 18 forks source link

Application menu not working with Plasma 5.12 #119

Closed psifidotos closed 6 years ago

psifidotos commented 6 years ago

In Plasma 5.12 the mechanism to detect application menus changed. I tried to activate it in AWC but unfortunately it doesnt work...

trmdi commented 6 years ago

Maybe you're not using the latest version of AWC.

psifidotos commented 6 years ago

Maybe you're not using the latest version of AWC.

@trmdi I checked it out... the only way to be activated in Latte is to add also a plasma menu plasmoid... are you using Plasma 5.12 and AWC and you see application menus correclty?

trmdi commented 6 years ago

Yes, I had the same issue like you. So I tried the git version, and it works.

aislanmaia commented 6 years ago

I confirm this issue. What is the release date for the latest version of AWC that works ?

trmdi commented 6 years ago

@aislanmaia Depending on your distro. What one do you use? Though you can use the git version whenever you want.

psifidotos commented 6 years ago

Depending on your distro. What one do you use? Though you can use the git version whenever you want.

I use the git version... and afterwards I reported the issue.

I will look into the plasma menu code and see if something changed in order to activate the functionality from plasma. I am aware that in plasma 5.12 the menu detection became automatic, and that is why the option in plasma systemsettings to configure application menu style has been removed. My guess is that only a small activating mechanism may be needed because when I add a plasma menu plasmoid elsewhere then AWC is also showing its menu.

psifidotos commented 6 years ago

I will look into the plasma menu code and see if something changed

Ok, I found it... plasma added a QDbusServiceWatcher in order to activate I think and this goes also in reverse... When the menu plasmoid is removed or the panel removed or Latte closes then plasma knows it because the connection is lost.. That is how new plasma knows at all times if a menu plasmoid is present... if it isnt even dynamically then it shows the menu in the app normally...

trmdi commented 6 years ago

Do you use the github or the cgit.kde version? I'm mentioning this: https://cgit.kde.org/plasma-active-window-control.git/

psifidotos commented 6 years ago

Oh.... I use the github! I didnt know there is one in kde... i will try that one...

kotelnik commented 6 years ago

Sorry to be that late to this party :). I have adapted the plasmoid to subscribe / unsubscribe to the appmenu service depending on its settings (Application Menu -> Enable application menu checkbox). So that should work fine. It is indeed only done in kde repositories. Sorry for your trouble.

The plasmoid is now in review process for addition to official KDE.

aislanmaia commented 6 years ago

Nice!!! I think I'll wait for the plasmoid to land officially in repos instead of using the git version. :tada:

@trmdi I'm using KDE Neon User Edition.