search

kotelnik / plasma-applet-active-window-control

Plasma 5 applet for controlling currently active window.
GNU General Public License v2.0
119 stars 18 forks source link

A option for font size. #12

Closed Psi57 closed 8 years ago

Psi57 commented 8 years ago

When I tried increasing the width of the panel,I found that the font looked small. So I think adding "Font size" could solve this.. : )

kotelnik commented 8 years ago

Yes, it could. But for now the font size is dependent on system-wide font size (System Settings -> Fonts). So it kind of keep the text size standardized with the rest of the system which is good in my opinion. It also allows to have more lines of the text when panel height is bigger. So I think the font shouldn't get bigger automatically, especially not when increasing widget width.

But yes, I can add the font size option if you feel it will be useful :)

Psi57 commented 8 years ago

I think it will be useful,for example,if the title just has one line and the width of panel is broad,The text will look small,and somebody(including me) want to make their system-wide font size and this of title different to fit the width,but there is no way to do that. So I think this option could be useful :)

kotelnik commented 8 years ago

Fair enough, try the latest commit :)

Psi57 commented 8 years ago

Thanks :)

Psi57 commented 8 years ago

It works :D !but it doesn't works when title shows "Plasma Desktop". It seems that you should add something in: screenshot_20151119_175318

and why not to use a way like kde system setting(such as "Sans 10","Monospace 9") but "times"? I think the first way would be better :)

kotelnik commented 8 years ago

Thanks for spotting the "Plasma Desktop" issue, I'll repair it.

Well, I just made the font scaling option because it was easier and I thought it will be sufficient. I think most people will only benefit from the size setting and leave the font to be the same as other fonts in their panel so the panel looks consistent. But if you think you'd use a different font, I'll add the option :)

Psi57 commented 8 years ago

No,I think it's enough now and font scaling option works well,too :)

kotelnik commented 8 years ago

Ok :) Now the scaling of "Plasma Desktop" should be fixed, too.

Psi57 commented 8 years ago

Thanks :)

Psi57 commented 8 years ago

It seems that you didn't update it at AUR,and "plasma5-applets-weather-widget-git" neither. I get the new version by reinstalling it. What happened?..

kotelnik commented 8 years ago

I know, I was about to do that along with updating kde-apps but I was waiting a while in case you find some problems with the new code. It's now updated.

Psi57 commented 8 years ago

OK Thanks :3

Psi57 commented 8 years ago

Wait....... I always hear from you the next day,but now you write back almost as soon as I send to you.. You stay up late?

kotelnik commented 8 years ago

Yes, I stayed up very late. As batman I needed to take care of some disturbances in the city... But this is probably off-topic for this bug so I'm closing it here :)

Psi57 commented 8 years ago

Thank you, batman :D 👍 But Be care about your health, anything is based on good health. :)