kotelnik / plasma-applet-active-window-control

Plasma 5 applet for controlling currently active window.
GNU General Public License v2.0
119 stars 18 forks source link

Restore custom svg icons option #122

Closed ishovkun closed 6 years ago

ishovkun commented 6 years ago

The AWC version that works with Plasma 5.12 at https://cgit.kde.org/plasma-active-window-control.git/ killed the option to use custom svg icons. I am using my custom non-aurorae (C++) theme (https://github.com/ishovkun/SierraBreeze) which AWC doesn't pick up, and I used to utilize the custom svg option to show similar-style buttons in AWC. Could you please restore the option?

trmdi commented 6 years ago

Will you have any updates for SierraBreeze?

ishovkun commented 6 years ago

Not planning any for now, why?

On Feb 9, 2018 9:09 AM, "trmdi" notifications@github.com wrote:

Will you have any updates for SierraBreeze?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kotelnik/plasma-applet-active-window-control/issues/122#issuecomment-364459919, or mute the thread https://github.com/notifications/unsubscribe-auth/AKozfwHzB1WSkk3GlSz3Cy772Ph0WOT5ks5tTF-ggaJpZM4SABBG .

kotelnik commented 6 years ago

Done in cgit :). Please reopen if problems occur.

trmdi commented 6 years ago

Works perfectly. Thank you @kotelnik !

trmdi commented 6 years ago

@kotelnik But it still can not expand ~ and $HOME in the path string.

kotelnik commented 6 years ago

You are right. I've just pushed a fix for ~. But is it a problem it does not expand env. variables?

trmdi commented 6 years ago

Ok, it's not a so big problem. Thank you @kotelnik !