kotelnik / plasma-applet-active-window-control

Plasma 5 applet for controlling currently active window.
GNU General Public License v2.0
119 stars 18 forks source link

[Regression] Crashes with fit text = always fit #26

Open protist opened 7 years ago

protist commented 7 years ago

To replicate:

  1. Set Fit text: to Always fit.
  2. Give Firefox focus. Text changes as expected.
  3. Change tab. Text does not change. CPU usage jumps immediately, then Plasma crashes in a few seconds.

This occurs every time. If I set Fit text: to Just elide, then it is stable again.

Up-to-date Arch Linux, running the latest plasma-applet-active-window-control r49.cef9ce2-1.

kotelnik commented 7 years ago

Interestingly I cannot replicate that, although I'm running updated Arch, too. But I'll be using this settings for some time and try to replicate the issue.

protist commented 7 years ago

Hmm… it's fine for me now too. Plasma upgraded a few times in the last 13 days (5.8.0-1 -> 5.8.1-1 -> 5.8.2-1), so perhaps one of those updates fixed it. Cheers!

protist commented 7 years ago

Oops, it's still a problem, just not quite as bad now. It's fine if I change to one tab slowly. However, if I shift through many tabs rapidly it still crashes plasmashell. This is 100% replicable. I tested again, and this still only occurs with fit text = always fit. FWIW I'm using this add-on to flip through tabs rapidly.

kotelnik commented 7 years ago

I still cannot reproduce it even with many firefox tabs being quickly changed by pressing and holding ctrl+tab (or using the addon). Anyway, I tried to blindly fix it. Can you please try latest git code?

protist commented 7 years ago

I'm… not sure if that partially fixed it. I tested several times. Firstly, it was definitely better immediately. Initially, I thought it was totally fixed. In the previous version, I had to scroll for ~2 seconds, now I had to scroll for ~10 seconds. However, on about my 5th crash this time, it again crashed after after only ~2 seconds.

I'm not sure why we're getting different results. Just in case there are some other settings that combine to create this bug, here are my full settings for active window control from ~/.config/plasma-org.kde.plasma.desktop-appletsrc

[Containments][37][Applets][101]
immutability=1
plugin=org.kde.activeWindowControl

[Containments][37][Applets][101][Configuration][Appearance]
buttonSize=1
buttonsPosition=UpperRight
controlButtonsSpacing=2
fitText=2
iconAndTextSpacing=0.5
showMinimize=true
slidingIconAndText=true
tooltipTextType=1

[Containments][37][Applets][101][Configuration][ConfigDialog]
DialogHeight=600
DialogWidth=800

[Containments][37][Applets][101][Configuration][MouseControl]
doubleClickMaximizes=false
leftClickAction=Expose
wheelDownAction=2
wheelUpMaximizes=true
kotelnik commented 7 years ago

Thanks for extended info. I tested it with your config but still cannot replicate the issue. Maybe I have too fast CPU that manages to compute the shrinking in time. I'll try on different machine and get back with results.

protist commented 7 years ago

Thank again @kotelnik. Let me know how you go. If you still can't replicate, I'm happy to troubleshoot more. I could possibly send you my full ~/.config/plasma-org.kde.plasma.desktop-appletsrc, but there's a fair bit of system-specific stuff there. Otherwise, I could try replicating in a virtual system, I guess.

protist commented 7 years ago

I just updated all my vcs packages in Arch, and noticed that this plasmoid was also updated from r50.ade9763-1 -> r53.25c0501-1. I thought I'd try test this bug again, just in case some of the new commits were relevant. It might be coincidence, but it's crashing more regularly; I only need to move a couple of tabs. Also, I managed to get this happening fairly easily.

screenshot

kotelnik commented 7 years ago

Hm, this looks weird. I know for sure that there is only one element showing the text so this looks like a QT graphical glitch. This is probably a long shot but what graphics card do You have? Do you use DRI2 or DRI3?

protist commented 7 years ago

I might have been a bit misleading with the screenshot that I selected. Mostly, you only see one or the other, i.e. the "correct" small text, or the "incorrect" large, offset text. I just picked the one where there were both because I thought it looks worse! This is how it normally is when it wigs out:

screenshot

I have a optimus/bumblebee laptop, which a switchable Intel/Nvidia GPU. Basically, I'm using the Intel onboard GPU. I haven't specified DRI2, so I think that means I'm using DRI3. FWIW I'm using UXA, because I had some problems with SNA that I can't remember now.

michaldybczak commented 7 years ago

I have the same issue on Manjaro, currently plasma 5.9.3. Plasmashell crashes on every left mouse click (which have no effect) so I'm blocked to do anything when any window is opened, so the only way out of this mess is alt+F4 all windows and then remove widget.

However, when I restored widget and just left default setting (fit text: just elide) and disabling window title, all works well just as I prefer.

I'm happy, because finally global menu works as it should be! Thanks! :D

kotelnik commented 7 years ago

Interesting... Previously I couldn't replicate this and now I can. But so far, I didn't find a solution. I'll try to fix it and if it just keep misbehaving, I'll probably remove the options... Anyway, thanks for all the useful info, I'll try to put it to good use :).

baddwin commented 7 years ago

Me too. I also set Fill width option checked. That caused my plasma crashed and threw errors:

File: ~/local/share/plasma/plasmoids/org.kde.activeWindowControl/contents/ui/main.qml:266:13: QML Text: Binding loop detected for property "computedWidth"
ghost commented 6 years ago

Still happens to me, can't even open settings to remove that setting

EDIT: crashes with any settings in title mode.

michaldybczak commented 6 years ago

Yeah, I confirm, bug is still around all that time later.