search

kotelnik / plasma-applet-active-window-control

Plasma 5 applet for controlling currently active window.
GNU General Public License v2.0
119 stars 18 forks source link

Add After Text AppMenu Option #47

Closed bkrith closed 7 years ago

bkrith commented 7 years ago

I add new option.. appmenu after text. See my screenshot below. Sorry for bad coding i'm just learning qml. I believe that is easier way for my dummy text component! :D Also I dont understand why github create for me a full fork of yours project!?!?

newmenuoption

MattMcHackit commented 7 years ago

With this option active, text appears to overrun into the appmenu. Is there a way of setting the spacing?

bkrith commented 7 years ago

Sorry mate... I apologize.. I found a solution.. I didnt set font attributes to Item testText (dummy Text). I fix it now but... best is to wait approve from kotelnik, because maybe is there easier way to do all that!

bkrith commented 7 years ago

@MattMcHackit Added also option to set the spacing and the limitation of title width from plasmoid settings

MattMcHackit commented 7 years ago

@bkrith That's perfect!! Thank you so much! Widget's pretty much perfect now!

MattMcHackit commented 7 years ago

Suggest this code is integrated, asap, @kotelnik

bkrith commented 7 years ago

Thank you so much! @kotelnik has did amazing work! I just tweak the already maded code!

kotelnik commented 7 years ago

Hi! Sorry it took me so long. I finally had time to look on the changes. First I wanted to integrate your pull request but I in the end I wanted to do the changes a bit differently. I think I've done all, You wanted to achieve with this pull. Please let me know if something is missing.

What I've done:

Anyway, thanks VERY much for Your code and suggestions.

bkrith commented 7 years ago

Yeap... that's it!! There was easier and more elegant way for do those things!(wtf?!?!... implicitWidth?!?! :D) I will try to learn QML... I must dig... Thank you so much!