[Feature Request] - Show Activity Name

kotelnik / plasma-applet-active-window-control

Plasma 5 applet for controlling currently active window.

GNU General Public License v2.0

119 stars 18 forks source link

[Feature Request] - Show Activity Name #95

Closed psifidotos closed 7 years ago

psifidotos commented 7 years ago

Currently AWC supports showing for the plasma desktop either the text Plasma Desktop or a text that the user has specified from the settings. I think it would be much more informative if instead the name of the current Activity was shown

kupiqu commented 7 years ago

That sounds like a good idea to me

psifidotos commented 7 years ago

pretty meaningful... :)

kupiqu commented 7 years ago

Somehow it doesn't work for me, the applet doesn't launch :/

psifidotos commented 7 years ago

plasma version? any errors?

kupiqu commented 7 years ago

Ok, it's fixed. Most absurd issue. There was a character issue after copying manually from github...

The thing is I didn't have right access to apply your patch and not being very proficient in git (didn't know how to apply your commit into my local branch), and given that there were only few changes in your commit I decided to apply them manually... and that was the result, my bad!

kupiqu commented 7 years ago

It's nice to have activity name in AWC, btw! :)

psifidotos commented 7 years ago

yeah... I use it also!!! It very easy and clean now to identify in which activity I am working on

kupiqu commented 7 years ago

Now that we have the activity name, extra points would be to have the option to move from one activity to another via a right click option... Would that make sense?

kupiqu commented 7 years ago

Currently it shows 'close', 'maximize', 'minimize', etc. These are windows options that do not apply when focus is on desktop. The option to switch activities would be more proper, I think...

psifidotos commented 7 years ago

this commit hasnt merged yet...

kupiqu commented 7 years ago

yeah, let's wait to see what @kotelnik thinks about all this... :)

kotelnik commented 7 years ago

Sorry, @kotelnik is on vacation and finally got to the internet :))). First, sorry for my late responses.

Thanks for the suggestions. I've just merged the @psifidotos pull (THANKS!) with some additional changes (I'm proposing %activity% placeholder instead of the checkbox). I think this is more flexible for the user... I hope it's ok for you?

As for the activity switching, I agree it should be added as a feature. Dropdown menu makes sence, @kubiqu, thanks for the suggestion! I'll look into it.

kotelnik commented 7 years ago

Please try latest commits for activity switching by standard right-click dropdown menu. Criticism appreciated :).

kupiqu commented 7 years ago

It works just great!