search

kotelnik / plasma-applet-network-monitor

Plasma 5 applet for monitoring active network connections.
GNU General Public License v2.0
18 stars 5 forks source link

"no device names" and "big numbers" do the same thing #8

Open Soukyuu opened 8 years ago

Soukyuu commented 8 years ago

I think this might be a bug. I expected "no device names" look like "full view" but without, well, the device names. However, selecting it makes the up/down arrows disappear and the number grow bigger. Setting it to "big numbers" shifts the numbers a bit, but the size stays the same.

kotelnik commented 8 years ago

I cannot reproduce this behaviour. When I change setting from "no device names" to "big numbers" I can see that it not only shifts the numbers but also made them bigger.

But maybe you've found a specific use-case where this size change is not visible?

Soukyuu commented 8 years ago

Uh, sorry, I kind of forgot about this issue. This is how the widget looks for me in different modes: nm_full nm_nodev nm_bignum nm_oneline

Note how everything except full view has weird spacing, most notably the "one line" mode. "big numbers" and "no device names" look nearly identical. I suspect it has something to do with me using a vertical panel though.

kotelnik commented 8 years ago

I can see you have a little bit different spacing then me but still "big numbers" was created from "no device names" to preserve more space for showing bigger numbers with container being wider (not squared). From the screenshots I can see that "big numbers" actually preserves a little vertical space in vertical panel.

The weird spacing in "full view" is caused by the need to keep the font smaller so higher numbers are not overflowing the arrows.

One line is mostly made for horizontal panels.

But maybe I'm not answering the right points you want me to... Please feel free to suggest some changes or ideas :)

Soukyuu commented 8 years ago

Basically, I have expected picture 2 to look like picture 1 (small text, arrows), but without the "enp5s0" text. There is almost no difference between picture 2 and 3 as it is now, at least for me.

kotelnik commented 8 years ago

You are right they look very similar. They was created on some users' demands to show bigger numbers. I think all 4 options are used by users so I'm probably going to leave them there of the time being.