kotelnik / plasma-applet-thermal-monitor

Plasma 5 applet for monitoring CPU, GPU and other available temperature sensors.
GNU General Public License v2.0
112 stars 64 forks source link

Solution #53: CPU temperature goes to off state #54

Open roachsinai opened 5 years ago

roachsinai commented 5 years ago

This pull request to solve #52 .

And also solve #16 and #53 these two are same problem, which I think the reason is #52 .

dvalter commented 5 years ago

This patch has fixed #16 / #52 / #53 in my case. Another solution might be removing the following lines of code.

diff --git a/package/contents/ui/main.qml b/package/contents/ui/main.qml
index 67e3f4c..6081d52 100644
--- a/package/contents/ui/main.qml
+++ b/package/contents/ui/main.qml
@@ -277,13 +277,8 @@ Item {

             dbgprint('adding source to systemmonitorDS: ' + source)

-            if (getSystemmonitorAvailableSources().indexOf(source) > -1) {
                 dbgprint('adding to connected')
                 addToSourcesOfDatasource(systemmonitorDS, source)
-            } else {
-                dbgprint('adding to sta')
-                systemmonitorSourcesToAdd.push(source)
-            }

         }

It works fine as well

roachsinai commented 5 years ago

Yes, caues comment this line,https://github.com/kotelnik/plasma-applet-thermal-monitor/blob/783536952c38bf26aefadb36d2dadd50c8ddc2c0/package/contents/ui/main.qml#L280 resulted in this variable systemmonitorAvailableSources never been used, so there is no error.

And I think the code which removed in your patch and variable systemmonitorAvailableSources is created to avoid source be added multiple times to systemmonitorDS. But each time systemmonitorDS was reset with every chage we did to this plasmoid at function reloadAllSources

https://github.com/kotelnik/plasma-applet-thermal-monitor/blob/783536952c38bf26aefadb36d2dadd50c8ddc2c0/package/contents/ui/main.qml#L214

So, I think it will also be fine you remove all things related to variable systemmonitorAvailableSources.

bodziek666 commented 5 years ago

Works fine for me on VoidLinux! Thank you for your effort. I hope this will be merged soon enough :) EDIT: works fine on ubuntu 19.04 on my second computer as well :)

kwhat commented 5 years ago

This still seems a bit wonky for me... It took a few reloads to get lm sensors to show up

roachsinai commented 5 years ago

Maybe you should use journalctl like #52 to find the error as I'm not using this plasmoid.

ivnish commented 2 years ago

It works. Please commit