search

kotelnik / plasma-applet-thermal-monitor

Plasma 5 applet for monitoring CPU, GPU and other available temperature sensors.
GNU General Public License v2.0
112 stars 64 forks source link

HDD sources not properly initialized on plasma start #7

Closed kotelnik closed 9 years ago

kotelnik commented 9 years ago

Since Plasma upgraded to 5.4 HDD temp values are always at 0 when I reboot or logout/login or restart plasma shell. Then I have to remove HDD entries in Thermal Monitor settings and add them again, then it works fine. It's not something related to udisks2 change, it was like that with hdd-temp in previous version.

kotelnik commented 9 years ago

I was unable to replicate this bug, yet. But it seams "executable" datasource is not ready on startup and therefore it is not properly initialized at the time connectedSources are filled. I'll do more testing and get back here with more info...

kotelnik commented 9 years ago

Still unable to come up with something so I will need your (kajzer from aur:) help.

1) While restarting plasma please see the plasma log - are there any messages containing "thermalMonitor"? Or you can just post me the whole log if you like.

2) In the latest commit I've added "Reload Temperature Sources" action. This should skip the need for re-adding the HDD sources. When clicking this action I'd also like to see the plasma log.

Thank you!

kopr12 commented 9 years ago

"Reload Temperature Sources" fixed it, thanks. I'll post log soon.

kopr12 commented 9 years ago

This is after login and HDD sources are at 0 http://pastebin.com/RfZwT6bh

and after "Reload Temperature Sources" : http://pastebin.com/4tpVyrwX

kotelnik commented 9 years ago

Thanks for the logs. I can see the same output I have. Though my HDD temperature gets always updated after a while... I'll add more debug logging and get back to you.

kotelnik commented 9 years ago

I just did some minor adjustments and added more debug logging. Please give me the log after login again. And let the other temperatures update several times so I can see the updates in the log... Thanks!

kopr12 commented 9 years ago

Maybe it's just me, maybe something went wrong during plasma upgrade from 5.3 to 5.4, I'm not sure. Anyway, if you keep "Reload Temperature Sources" option in future versions all is good ! :)

kotelnik commented 9 years ago

Sure, that is the least I can do :)

kotelnik commented 9 years ago

Hi! I finally encountered the issue you were having and possibly fixed it with the latest commit. Please try if it is fixed for you, too. Thanks!

kopr12 commented 9 years ago

Hi, sorry for late reply ! It's working fine now, cheers :)

kotelnik commented 9 years ago

Glad to hear that :)