search

kotelnik / plasma-applet-weather-widget

Plasma 5 applet for displaying weather information from yr.no server.
GNU General Public License v2.0
88 stars 42 forks source link

Meterogram doesn't display nicely with non-default scaling/font selection #25

Closed tz-m closed 8 years ago

tz-m commented 8 years ago

On my 3200x1800 display, the meterogram is too tiny to read, and the text is jumbled. It would be great if the system settings related to hidpi screens could be taken into account. e.g. display scaling, forced font dpi.

Cheers for the widget though!

snapshot1

kotelnik commented 8 years ago

Hi! Thanks for the report!

You are right, hidpi is not taken into account. I'll try to fix that. But I think I've already fixed the font size disproportions. Can you please check that you are running 1.6.6 version of the plasmoid? (Look at Settings -> General: top right corner) screenshot_20160330_070148

kotelnik commented 8 years ago

Nevermind, I can simulate the issue, too. Sorry for the noise :). I'll fix it.

tz-m commented 8 years ago

I've managed to make some changes where I multiplied many of the hard-coded pixel values by the relevant quantity... units.devicePixelScale or theme.defaultFont.pixelSize

Tested on my 13" screen, and it works. From this: snapshot2

to this: snapshot3

As you know, the meteogram downloaded from yr.no cannot be scaled up without looking terrible. So it's better to render it...

P.S. Personally I prefer the dates in "day/month" format, rather than "day.month." Sorry if this goes against your design goals.

kotelnik commented 8 years ago

Thank You for the font fixing! I've made a little adjustments to the meteogram font to be smaller because e.g. the hours were too big. I hope You don't mind.

As for the day/month I've used selfishly czech style with dots. I'll try to use users locale to determine what to show or add a configuration option for that.

kotelnik commented 8 years ago

If you still find the font in meteogram too tiny, let me know, I'll make this whole area (along with the font) bigger - this time with hiDPI in mind of course :).

tz-m commented 8 years ago

Looks great, thanks!