Appearance tweaks and fixes

kotelnik / plasma-applet-weather-widget

Plasma 5 applet for displaying weather information from yr.no server.

GNU General Public License v2.0

88 stars 42 forks source link

Appearance tweaks and fixes #8

Closed nowrep closed 8 years ago

nowrep commented 8 years ago

This fixes number of small issues in the whole applet, please see each commit for explanation.

Also, I have few notes for you:

Plasma Components should be used in applet (eg. Text, Label -> PlasmaComponents.Label). Plasma Components are using the Plasma theme by default, so you don't have to take care of it.
Plasma Theme (theme) colors should not be used in Config, because it doesn't use Plasma widgets.
You should prefer positioning with anchors and not enforce width/height of items when not necessary.

Apart from this, cool applet, thanks ;)

kotelnik commented 8 years ago

Very nice! Thank you, díky moc :-) Thanks also for all the advices above, it's highly useful and I'll use them to correct the rest of my widgets...

Although I'll have to change some of the styling in ConfigGeneral since some texts are not visible with Colours set to Breeze Dark while desktop theme is set to Breeze (I know, rare scenario...).

Thanks again, the tray version looks much better now!

nowrep commented 8 years ago

Although I'll have to change some of the styling in ConfigGeneral since some texts are not visible with Colours set to Breeze Dark while desktop theme is set to Breeze (I know, rare scenario...).

Not a rare scenario, you just need to use Label instead of Text in config ;)

kotelnik commented 8 years ago

Thanks, that's exactly what I did:)