search

kotest / kotest-intellij-plugin

The official Kotest plugin for Intellij and Android Studio
Apache License 2.0
179 stars 25 forks source link

Fix JRE selection not being detected as changed #201

Closed Kantis closed 2 years ago

Kantis commented 2 years ago

Fixes https://github.com/kotest/kotest/issues/3098

sksamuel commented 2 years ago

The first time the dialog is opened it won't have been defined externally. So I wondered if it would be null

On Fri, Jul 8, 2022, 1:27 AM Emil Kantis @.***> wrote:

@.**** commented on this pull request.

In src/main/kotlin/io/kotest/plugin/intellij/KotestConfiguration.kt https://github.com/kotest/kotest-intellij-plugin/pull/201#discussion_r916501249 :

@@ -179,6 +188,8 @@ class KotestConfiguration(name: String, factory: ConfigurationFactory, project:

override fun readExternal(element: Element) {
   super.readExternal(element)
  • alternativeJrePath = JDOMExternalizerUtil.readField(element, AlternativeJrePathField)

I'm not really sure how to set it to null. Closest I got was selecting some empty line in the JRE selector, saving the configuration and then loading it again and it would load back as null without issue.

— Reply to this email directly, view it on GitHub https://github.com/kotest/kotest-intellij-plugin/pull/201#discussion_r916501249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGQRQA3UASW2MVXGLODVS7C6JANCNFSM527A327A . You are receiving this because your review was requested.Message ID: @.***>