search

kotest / kotest-intellij-plugin

The official Kotest plugin for Intellij and Android Studio
Apache License 2.0
173 stars 19 forks source link

Plugin does not run single test or context of tests #88

Closed neckbosov closed 4 years ago

neckbosov commented 4 years ago

If I try run context or single test, all test in class run instead. Kotlin 1.4.0, Kotest 4.2.0, kotest-intellij-plugin 1.1.12-IC-2020.1

sksamuel commented 4 years ago

I cannot duplicate this. Can you copy n paste the final part of the argument string when you start a test. Should look something like io.kotest.engine.launcher.MainKt --spec com.sksamuel.kotest.specs.describe.DescribeSpecBangTest --testpath Foo --writer teamcity

neckbosov commented 4 years ago

io.kotest.framework.launcher.LauncherKt --spec lambda.bigsister.server.api.CommonTests --testpath Login/Logout --writer teamcity

sksamuel commented 4 years ago

I wonder if the / in the test name is causing issues. Can you rename the test to Login Logout

On Sun, 23 Aug 2020, 04:45 neckbosov, notifications@github.com wrote:

io.kotest.framework.launcher.LauncherKt --spec lambda.bigsister.server.api.CommonTests --testpath Login/Logout --writer teamcity

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kotest/kotest-intellij-plugin/issues/88#issuecomment-678752900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGSWNZOQCI3DYGL2CADSCDQNFANCNFSM4QHS7UDA .

neckbosov commented 4 years ago

I rename, but it is not working too. io.kotest.framework.launcher.LauncherKt --spec lambda.bigsister.server.api.CommonTests --testpath LoginLogout --writer teamcity Such thing happens also if I try to run a single test in this class: io.kotest.framework.launcher.LauncherKt --spec lambda.bigsister.server.api.CommonTests --testpath Injection --writer teamcity

sksamuel commented 4 years ago

The parameters all look correct. I've added more tests for the TestPathTestCaseFilter which is the class that does the work of deciding which tests to run and they all pass fine. https://github.com/kotest/kotest/commit/098a92789dbb0128bbc786f58d23d45cabcc5af0

Is your build perhaps bringing in an older version of kotest as well ?

kharf commented 4 years ago

I have the same issue. After upgrading to kotest 4.2.0 and plugin 1.1.12-IC-2020.1 and removing the console runner I cannot run a single test in StringSpec.

class ValidatorSpec : StringSpec({

    "Do something" {
      "bla" shouldBe "bla"
    }

    "Another test" {
       "blabla" shouldBe "blabla"
    }
})
neckbosov commented 4 years ago

The parameters all look correct. I've added more tests for the TestPathTestCaseFilter which is the class that does the work of deciding which tests to run and they all pass fine. kotest/kotest@098a927

Is your build perhaps bringing in an older version of kotest as well ?

No, I use only Kotest 4.2.0. With Kotlin 1.3.72, Kotest 4.1.1 and console-runner in older version of my project it works well.

sksamuel commented 4 years ago

I've no idea why it's not working for you. Perhaps there's some mismatch in versions on my end so I don't see the issue. There is a plugin update that was submitted on friday and I was hoping it would have been approved today, if not then tomorrow. Let's try that and see if the issue persists.

On Mon, 24 Aug 2020 at 04:08, neckbosov notifications@github.com wrote:

The parameters all look correct. I've added more tests for the TestPathTestCaseFilter which is the class that does the work of deciding which tests to run and they all pass fine. kotest/kotest@098a927 https://github.com/kotest/kotest/commit/098a92789dbb0128bbc786f58d23d45cabcc5af0

Is your build perhaps bringing in an older version of kotest as well ?

No, I use only Kotest 4.2.0. With Kotlin 1.3.72, Kotest 4.1.1 and console-runner in older version of my project it works well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kotest/kotest-intellij-plugin/issues/88#issuecomment-679006393, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGW5TKLD3X4EZ7OKBHDSCIUXJANCNFSM4QHS7UDA .

neckbosov commented 4 years ago

Update does not change situation. Something was broken after 4.2.0.RC2, because Kotest 4.2.0.RC2 works good.

neckbosov commented 4 years ago

Update: with current version of plugin running single test or context with Kotest 4.2.0.RC2 does not work.

sksamuel commented 4 years ago

So you're on 1.1.16 plugin now ?

On Wed, 26 Aug 2020 at 05:50, neckbosov notifications@github.com wrote:

Update: with current version of plugin running single test or context with Kotest 4.2.0.RC2 does not work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kotest/kotest-intellij-plugin/issues/88#issuecomment-680806186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGUWONU2GVL54KQ65QLSCTSHJANCNFSM4QHS7UDA .

kharf commented 4 years ago

With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me.

sksamuel commented 4 years ago

What version of intellij and what os ?

On Wed, 26 Aug 2020 at 06:42, Kevin Fritz notifications@github.com wrote:

With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kotest/kotest-intellij-plugin/issues/88#issuecomment-680827763, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGRVG3Z5XBJUVNCQGJTSCTYLDANCNFSM4QHS7UDA .

Obirah commented 4 years ago

I'm also experiencing problems with the following setup:

For any spec or single test I execute from IntelliJ, I get "Test framework quit unexpectedly".

If I downgrade my project to KoTest 4.2.0.RC2, I can at least execute full specs from IntelliJ, but no single specs (this is the known issue 87, I think)

kharf commented 4 years ago

What version of intellij and what os ? … On Wed, 26 Aug 2020 at 06:42, Kevin Fritz @.***> wrote: With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGRVG3Z5XBJUVNCQGJTSCTYLDANCNFSM4QHS7UDA .

Intellij 2020.2.1 and manjaro linux

sksamuel commented 4 years ago

I'm also experiencing problems with the following setup:

  • MacOS 10.15.6
  • IntelliJ 2020.2.1
  • KoTest plugin 1.1.16-IC-2020.1
  • KoTest 4.2.0

For any spec or single test I execute from IntelliJ, I get "Test framework quit unexpectedly".

If I downgrade my project to KoTest 4.2.0.RC2, I can at least execute full specs from IntelliJ, but no single specs (this is the known issue 87, I think)

plugin 1.1.16 should work against 4.1.3 4.2.0 and the upcoming 4.2.1

The Test framework quit unexpectedly is sometimes an exception thrown before Kotest gets setup.

sksamuel commented 4 years ago

What version of intellij and what os ? … On Wed, 26 Aug 2020 at 06:42, Kevin Fritz @.***> wrote: With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGRVG3Z5XBJUVNCQGJTSCTYLDANCNFSM4QHS7UDA .

Intellij 2020.2.1 and manjaro linux

Ok I'm on ubuntu and 2020.2.1. I can run individual string specs from here https://github.com/sksamuel/hoplite/blob/master/hoplite-core/src/test/kotlin/com/sksamuel/hoplite/decoder/DataClassDecoderTest.kt

Do you want to clone that project and try that test class? Then we know if it's plugin vs framework issue.

kharf commented 4 years ago

What version of intellij and what os ? … On Wed, 26 Aug 2020 at 06:42, Kevin Fritz @.***> wrote: With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGRVG3Z5XBJUVNCQGJTSCTYLDANCNFSM4QHS7UDA .

Intellij 2020.2.1 and manjaro linux

Ok I'm on ubuntu and 2020.2.1. I can run individual string specs from here https://github.com/sksamuel/hoplite/blob/master/hoplite-core/src/test/kotlin/com/sksamuel/hoplite/decoder/DataClassDecoderTest.kt

Do you want to clone that project and try that test class? Then we know if it's plugin vs framework issue.

yea this worked. So this is not a plugin issue, instead it must be indeed on kotest side I suppose?

sksamuel commented 4 years ago

What version of intellij and what os ? … On Wed, 26 Aug 2020 at 06:42, Kevin Fritz @.***> wrote: With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGRVG3Z5XBJUVNCQGJTSCTYLDANCNFSM4QHS7UDA .

Intellij 2020.2.1 and manjaro linux

Ok I'm on ubuntu and 2020.2.1. I can run individual string specs from here https://github.com/sksamuel/hoplite/blob/master/hoplite-core/src/test/kotlin/com/sksamuel/hoplite/decoder/DataClassDecoderTest.kt Do you want to clone that project and try that test class? Then we know if it's plugin vs framework issue.

yea this worked. So this is not a plugin issue, instead it must be indeed on kotest side I suppose?

Great, and I've duplicated the issue in 4.2.0 now.

It works in 4.2.0.556-SNAPSHOT, so will be fixed once I release 4.2.1 (which is happening in the next few hours).

neckbosov commented 4 years ago

What version of intellij and what os ? … On Wed, 26 Aug 2020 at 06:42, Kevin Fritz @.***> wrote: With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGRVG3Z5XBJUVNCQGJTSCTYLDANCNFSM4QHS7UDA .

Intellij 2020.2.1 and manjaro linux

Ok I'm on ubuntu and 2020.2.1. I can run individual string specs from here https://github.com/sksamuel/hoplite/blob/master/hoplite-core/src/test/kotlin/com/sksamuel/hoplite/decoder/DataClassDecoderTest.kt

Do you want to clone that project and try that test class? Then we know if it's plugin vs framework issue.

Ok, in this project works, but it uses Kotlin 1.3.72 and Kotest 4.1.3, I use Kotlin 1.4.0 and Kotest 4.2.0. Intellij IDEA Ultimate 2020.2, manjaro linux.

kharf commented 4 years ago

What version of intellij and what os ? … On Wed, 26 Aug 2020 at 06:42, Kevin Fritz @.***> wrote: With kotest 4.2.0 and plugin 1.1.16-IC-2020.1 a single test still executes all tests of a StringSpec for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGRVG3Z5XBJUVNCQGJTSCTYLDANCNFSM4QHS7UDA .

Intellij 2020.2.1 and manjaro linux

Ok I'm on ubuntu and 2020.2.1. I can run individual string specs from here https://github.com/sksamuel/hoplite/blob/master/hoplite-core/src/test/kotlin/com/sksamuel/hoplite/decoder/DataClassDecoderTest.kt Do you want to clone that project and try that test class? Then we know if it's plugin vs framework issue.

Ok, in this project works, but it uses Kotlin 1.3.72 and Kotest 4.1.3, I use Kotlin 1.4.0 and Kotest 4.2.0. Intellij IDEA Ultimate 2020.2, manjaro linux.

Yes, but if it still works with the newest plugin version, it means that it is not a plugin issue

neckbosov commented 4 years ago

Solved in Kotest 4.2.2