README improvements - Githubissues

kothar / brotli-go

Not maintained -> see itch.io's more up-to-date fork 👉

https://github.com/itchio/go-brotli

MIT License

82 stars 9 forks source link

Closed fasterthanlime closed 8 years ago

fasterthanlime commented 8 years ago

In this PR:

:trophy: badges for both godoc & travis
Simpler examples (with a reference to the full test case)
A note about VERSION.md
Syntax highlighting for code samples
Minor markdown syntax pet peeves (autolink is a Github-Flavored Markdown extension, for example)

Note that #6, #7 and #8 are blockers for this :)

fasterthanlime commented 8 years ago

Beautiful :) thanks for merging all those so quickly!

kothar commented 8 years ago

No problem, thanks for contributing so much work to getting the full bindings working!

There's one failed build on Travis-CI, but I can't work out exactly what's going on with the gox command: https://travis-ci.org/kothar/brotli-go/jobs/91662546

fasterthanlime commented 8 years ago

There's one failed build on Travis-CI

It can safely be ignored: I included what I know about it in the .travis.yml file directly:

(It fails because the OSARCH environment variable is empty)

Maybe someone at @travis-ci can help us figure out why it happens? Is it because of my include-only usage of the build matrix?