kothariji / SyntaxMeets

Syntaxmeets. Create rooms 🏠 Call your friends πŸ‘¬πŸΌ Sip Chai, β˜• Chat, Create, and CodeπŸ‘¨β€πŸ’». A coding platform to code simultaneously πŸš€ with your friends and design your algorithms on SyntaxPad.πŸ’«βœ¨
https://syntaxmeets.vercel.app
MIT License
168 stars 59 forks source link

Alert converted to toast #116

Closed AmeyaJain-25 closed 3 years ago

AmeyaJain-25 commented 3 years ago

Issue: #109 The html alert is converted to material UI snackbar. Here are the screenshot for it.

Screenshot from 2021-04-10 22-45-00 Screenshot from 2021-04-10 22-45-30

vercel[bot] commented 3 years ago

@AmeyaJain-25 is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/kothariji/syntaxmeets/3nXMky8m8T8A8Bzcg8nd9P5oj5DW
βœ… Preview: https://syntaxmeets-git-fork-ameyajain-25-alerttotoast-kothariji.vercel.app

Vishv07 commented 3 years ago

@AmeyaJain-25 Alert could have done better in terms of UI. and what if we use Error message alert that we are using for code editor errors. @kothariji

kothariji commented 3 years ago

Great work @AmeyaJain-25, but according to the UI perspective, their alerts are not dissolving with the website UI, so instead of that we can use the traditional alerts which are there in SyntaxMeets for the copy room ID, and we can directly redirect the user to the homepage.

kothariji commented 3 years ago

@AmeyaJain-25 Alert could have done better in terms of UI. and what if we use Error message alert that we are using for code editor errors. @kothariji

Yes exactly what I mean to say. @Vishv07 πŸ™Œ

AmeyaJain-25 commented 3 years ago

Yep Sure @Vishv07 @kothariji Great Idea.

Initially I thought that user have to been given a dialog for it.

I tried showing just the error and then redirect, but I was redirecting immediately and the notification is not able to see. What I think now is, I'll show the default error message and then after 1 sec or 2 sec delay, I'll redirect the page. Would that be fine?