kothariji / SyntaxMeets

Syntaxmeets. Create rooms 🏠 Call your friends πŸ‘¬πŸΌ Sip Chai, β˜• Chat, Create, and CodeπŸ‘¨β€πŸ’». A coding platform to code simultaneously πŸš€ with your friends and design your algorithms on SyntaxPad.πŸ’«βœ¨
https://syntaxmeets.vercel.app
MIT License
168 stars 59 forks source link

added code share feature and image of code snippet #137

Closed subhangi2731 closed 3 years ago

subhangi2731 commented 3 years ago

closes issue #74

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

subhangi2731 commented 3 years ago

@kothariji please merge my pr

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/kothariji/syntaxmeets/DrCVKWsozqLxnJdsvFSkL2A1TmH6
βœ… Preview: https://syntaxmeets-git-fork-subhangi2731-code-snippet-kothariji.vercel.app

subhangi2731 commented 3 years ago

@kothariji please merge my pr

kothariji commented 3 years ago

Hi @subhangi2731, I am facing this issue image

subhangi2731 commented 3 years ago

@kothariji ok let me check

subhangi2731 commented 3 years ago

@kothariji I am not getting any error, I am getting correct link, can I mention steps to reproduce the error

subhangi2731 commented 3 years ago

@kothariji I have done and tested everything

kothariji commented 3 years ago

@subhangi2731 ok wait, I'll check again.

kothariji commented 3 years ago

Great @subhangi2731, it's working fine πŸš€ But the thing is, the link is not accessible properly. Its inside alert, which closes automatically. So instead that can you please place the link somewhere else where it can be easily accessed. For example image

Here we can create a modal, similar to the one which google meets have. Where we can give the generated link of code snippet

subhangi2731 commented 3 years ago

@kothariji for creating the modal this issue should be level 3 because then there are many things to be done and I have already done so much in this issue

subhangi2731 commented 3 years ago

can u please assign level 3 to this @kothariji cause for the level 2 part I have already done that

kothariji commented 3 years ago

@subhangi2731 cool! I agree with you here. So for this issue to be level3

  1. Add a modal, in which there would be a link to the generated code snippet code.
  2. Add some kind of a loader, as it is async/await request, so it may take a few seconds to generate, till that time there should be a loader in the screen.

On fulfilling all the above requirements, I will change the tags from Lvl2 to LVl3

subhangi2731 commented 3 years ago

https://user-images.githubusercontent.com/53938490/120095773-60733800-c145-11eb-847a-b14b23e972ad.mp4

subhangi2731 commented 3 years ago

@kothariji please merge my pr I have done everything loader and modal

subhangi2731 commented 3 years ago

thanks @kothariji can u pleasw add the level tag and labels

kothariji commented 3 years ago

@subhangi2731 Done πŸš€ , please check !