kothariji / SyntaxMeets

Syntaxmeets. Create rooms 🏠 Call your friends πŸ‘¬πŸΌ Sip Chai, β˜• Chat, Create, and CodeπŸ‘¨β€πŸ’». A coding platform to code simultaneously πŸš€ with your friends and design your algorithms on SyntaxPad.πŸ’«βœ¨
https://syntaxmeets.vercel.app
MIT License
168 stars 59 forks source link

Issue resolved #61

Closed AmeyaJain-25 closed 3 years ago

AmeyaJain-25 commented 3 years ago

This PR is realted to issue #48

There isn't a need to change the UI for alerts. It wasn't the issue related to UI, but for validation. When I went through the code, the alert which was coming was from different thing i.e the syntaxrooms.

About the validation, when we hit create room with empty name, it leads to the syntaxRoom and the checking is done over there, whether room id or name is empty or not, which was wrong. I've added the validation on the home page modal itself. As there was no option to stop the redirection on click as we are using MUIButton, so I have used the disability property. I've disabled the buttons till the name or room id is entered or not. Room id validation is till the characters have proper 14 digit code or not. If these are fulfilled, then it allows user to click and enter or join a room. Hence validation is done properly.

vercel[bot] commented 3 years ago

@AmeyaJain-25 is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel.

@kothariji first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/kothariji/syntaxmeets/9JK1gtPupye7wMJiDgEmqBJpYfuf
βœ… Preview: https://syntaxmeets-git-fork-ameyajain-25-validation-alert-is-21e500.vercel.app

AmeyaJain-25 commented 3 years ago

Yes, and that alert was showing when we enter a room without name. So I thought to add some validation before only to avoid later checks.

Yes, I'll add the regex pattern for the room is validation and make PR again

kothariji commented 3 years ago

Yes, and that alert was showing when we enter a room without name. So I thought to add some validation before only to avoid later checks.

Yes, I'll add the regex pattern for the room is validation and make PR again

yes πŸ”₯ Great πŸš€

AmeyaJain-25 commented 3 years ago

Added the Regex pattern validation