Room ID generation - Githubissues

kothariji / SyntaxMeets

Syntaxmeets. Create rooms 🏠 Call your friends 👬🏼 Sip Chai, ☕ Chat, Create, and Code👨‍💻. A coding platform to code simultaneously 🚀 with your friends and design your algorithms on SyntaxPad.💫✨

https://syntaxmeets.vercel.app

MIT License

168 stars 59 forks source link

Room ID generation #68

Closed Vaibhav-afk closed 3 years ago

Vaibhav-afk commented 3 years ago

generateRoomId method inside home.js

The room Id generated from this method will be inefficient and less secure, as it is generated from set of lowerCase & upperCase Alphabets.

solution

We can use uuid npm package for generating unique Id's, created from cryptographically-strong random values.

Screenshots

kothariji commented 3 years ago

Hi @Vaibhav-afk, First of all, thank you so much for taking out the time to create this issue.

Generally, we thought to make room-Id more user-friendly and in a presentational format. So we came up with a pattern xxxx-yyyy-zzzz. Also, the possible numbers of rooms are 52^12 which is huge. So I feel, currently, there is not a need for UUID generated room-Ids

What are your thoughts on this @Vaibhav-afk ?

Vaibhav-afk commented 3 years ago

Yeah! I agree with you.