kotlin-graphics / glm

jvm glm
122 stars 20 forks source link

remove .idea, .gitignore #32

Closed Bixilon closed 1 year ago

Bixilon commented 1 year ago

That folder should not belong in git

Spliite das mal in mehrere PRs

elect86 commented 1 year ago

Are you sure?

I follow the Intellij guidelines in this regards

Bixilon commented 1 year ago

Oh, wow, did not know that. I am never commiting in into the repository.

But at least the .iml should go, that breaks things when cloning

elect86 commented 1 year ago

It looks you are definitely right

Items you may want to exclude from sharing:

.iml files and .idea/modules.xml file for the Gradle or Maven based projects since these files will be generated on import

Mind undoing partially the commit to leave out .iml files?

Bixilon commented 1 year ago

Sure, that is not the problem.

But honestly if you look at the files...I only see, that it might be interesting to keep the run configurations but I don't really see a valueable part of the others, imho they get generated.

elect86 commented 1 year ago

ah wait, now I got it.. the .gitignore is missing!

That's definitely an error, is this one fine for you? I'm using it across all the project and it's generated using the official guidelines

Bixilon commented 1 year ago

Yep, that one looks great.

Bixilon commented 1 year ago

Mostly updaded, left out the unneeded files

elect86 commented 1 year ago

Thanks