search

kotlin-graphics / glm

jvm glm
122 stars 20 forks source link

improve mat4 transforming performance #41

Closed Bixilon closed 8 months ago

Bixilon commented 8 months ago

Tests passing, its actually faster and allocates 0 memory now.

elect86 commented 8 months ago

I wanted to change that sooner or later myself, thanks

Bixilon commented 8 months ago

How about a release? (also pushes to maven hopefully)

elect86 commented 8 months ago

Personally I'd like to switch this to Multiplatform and then release.

I've already ported unsigned to MP, I just have to finish the last polishes and it's ready

Can you release it in the meanwhile? Which number would make sense to upgrade?

Bixilon commented 8 months ago

Can understand that. I could release but I don't want version numbers to differ from this repository and maven.

I mean it contains breaking changes, but build 12 would probably still fit?

elect86 commented 8 months ago

ok, it makes sense actually, we can release it

I'll look into it, build is fine I guess?

Bixilon commented 8 months ago

For maven its actually enough if you push a tag I guess. If not, I will investigate it.

Am 22. Oktober 2023 23:07:23 MESZ schrieb Giuseppe Barbieri @.***>:

ok, it makes sense actually, we can release it

I'll look into it, build is fine I guess?

-- Reply to this email directly or view it on GitHub: https://github.com/kotlin-graphics/glm/pull/41#issuecomment-1774199032 You are receiving this because you authored the thread.

Message ID: @.***>

Bixilon commented 8 months ago

Just published the tag v0.9.9.1-build-12 which builds version 0.9.9.1-12. Not publishing it to mary though, no clue how that works.

Publishing to maven central failed, because it is not authorized. Have you stored the signing key and the credentials for in as a secret? I sent you them per email a while ago (add them https://github.com/organizations/kotlin-graphics/settings/variables/actions/new). I'll publish this release manually.

elect86 commented 8 months ago

I still have theme somewhere

However, another issue I recall it now is that we have now maven central and mary, I wonder if we can automatically switch dependencies regarding where we are publishing (eg maven central shall fetch the maven central deps)

Bixilon commented 8 months ago

Sent it on 7/6/23.

That is actually a must have, otherwise things break and dependecies can not be resolved. I am not sure how to make it though. For glm it is really easy, there are no dependencies. kool and unsigned are runtime dependencies (i.e. add them if you need it). For projects that really require it, there needs to be a variable set that calles implementation in the dependecy section with the corresponding values. The other option is: Manipulating the generated pom.xml is farily easy, but changing the gradle build info (that is loaded my gradle and published too) is a hazard.