Docking bugfixes - Githubissues

zeroeightysix commented 3 years ago

This PR aims to fix a handful of small bugs in the docking branch.

Feel free to review, but I will probably be pushing more to this PR, so please do not merge yet.

[X] Docked tabs close themselves immediately after creation
[X] Tab name offset would often be -1 as when they were initialised, the wrong flags were checked (causing an index out of bounds exception when trying to access the name)
[ ] The window border of a window with docked tabs is offset to the bottom right
[ ] The first window in a window with docked windows does not appear to have a tab (also visible in image above)

Also see #140 for issues to fix

elect86 commented 3 years ago

@zeroeightysix you can start merging if you want ;)

zeroeightysix commented 3 years ago

@zeroeightysix you can start merging if you want ;)

Sorry for leaving this stale. I haven't been writing much code for the project I use imgui in, so the incentive to fix bugs here has gone as well. I'll fix the merge conflicts.

elect86 commented 3 years ago

Np, thanks for the fixes though!

kotlin-graphics / imgui

Docking bugfixes #154