kotlin-graphics / openvr

OpenVR SDK
http://steamvr.com
BSD 3-Clause "New" or "Revised" License
37 stars 0 forks source link

Consider adding OpenVR libs as a git submodule? #2

Closed stephenohair closed 6 years ago

stephenohair commented 6 years ago

Very minor but might take the hassle out of pushing the new binaries each time they're updated by Valve/OpenVR.

https://git-scm.com/book/en/v2/Git-Tools-Submodules

elect86 commented 6 years ago

It's an interesting idea..

But I lack experience with git submodules, do you have some?

I also may look into Gradle if it's possible to do that

stephenohair commented 6 years ago

I looked further into this. I found two issues with using git submodules.

I've put an issue in to openvr valvesoftware/openvr#764 to see if they'd consider migrating their binaries to conan-center. We could then just point gradle to the repo and only need to bump up version numbers to update sdk versions.

elect86 commented 6 years ago

Yeah, I recall one blog article talking about using git submodules only under some specific conditions (~constraints)

Hopefully I'll play with Gradle sooner

Thanks for your efforts, though

elect86 commented 6 years ago

Ps: the blog was the official one, you can read the notes I meant at the end

Pps: playing with this one at the moment

stephenohair commented 6 years ago

Nice job with using gradle for downloading the dependencies. I once had to do something similar for android library dependencies a long time ago.

elect86 commented 6 years ago

Thanks Stephen..

Although I left out Mac Os because I couldn't find a way to recursively download that (it"s based on multiple directories), but I dont think we have an user base for that..

I'll look into that in the long period though