search

kotlin-hands-on / jvm-js-fullstack

https://play.kotlinlang.org/hands-on/Full%20Stack%20Web%20App%20with%20Kotlin%20Multiplatform/
122 stars 148 forks source link

fix missing ktor-server-core-jvm for jvmMain sources #19

Closed harrisonmetz closed 2 years ago

harrisonmetz commented 2 years ago

It seems that the ktor-server-core-jvm was missing from the jvmMain sources. By only having the "common" core it could not resolve the @KtorDsl. This fixes #18 .

SebastianAigner commented 2 years ago

Thanks so much for the contribution @harrisonmetz! Awesome to see a fix that works right away – but I've got a hunch there's a bigger problem afoot somewhere here. I have a hunch this should work as is, and there might be some metadata missing in Ktor to indicate this accordingly. I'll merge your code and rebase the final branch accordingly, but I'll have to double check if this is actually the right approach or more akin to a bandaid 😉