search

kotlinx / ast

Generic AST parsing library for kotlin multiplatform
Apache License 2.0
326 stars 23 forks source link

Add support for annotations to KlassIdentifier refs. Issue#95 #100

Closed birajpatel closed 3 months ago

birajpatel commented 1 year ago

Fixes : https://github.com/kotlinx/ast/issues/95

birajpatel commented 1 year ago

@drieks Please review 😃.

drieks commented 1 year ago

Hi @birajpatel , thank you very very much! Your pull request looks very good! Sadly, there is a problem with the build system. To fix this, I want to move the build to gitlab actions. I already migrated https://github.com/drieks/antlr-kotlin in this way (this is a dependency used by kotlinx.ast). The release action is working fine: https://github.com/drieks/antlr-kotlin/actions/runs/4536723459/jobs/8409480096, but the publication to maven cental is not working (https://github.com/kotlinx/ast/issues/89)

When this is fixed, I can use almost the same action for kotlinx.ast to upload it to maven central. after this, the build should be stable and this pull request should be able to build.

I'm really very sorry that the build is broken and that's why the pull request can't be merged at the moment :(

birajpatel commented 1 year ago

@drieks Oh, thats really sad, Actually we are using this library for one of our internal tools and merging this fix will unblock some pending things. (Because without my fix above the parser just fails to parse the file). Please try to help ASAP 😄 🙏 I saw many other folks are also awaiting the mavenCentral release. 🙏

renatacmn commented 1 year ago

Hey @drieks! Any news on this? I'm also interested in this fix 👀

aaronfodor commented 1 year ago

Any update on this? It would be very good to have this fix merged @drieks

drieks commented 1 year ago

Hi, I'm really sorry, I don't have much time at the moment. one possibility would be to temporarily expand the antlr-kotlin support. but I'm still not sure why publishing to maven central doesn't work. in the end not all jar files that were necessary were created. and I think we will run into the same problem with this library here, because it seems to be a multiplatform publishing issue.