search

kotoMJ / security-showcase-android

Sample application pointing some security related practices on Android device.
130 stars 11 forks source link

Simplify installation - dependency definition #36

Closed kotoMJ closed 5 years ago

kotoMJ commented 6 years ago

Current installation requires to define android-keystore-compat itself. But it also requires to list all implementation dependencies.

dependencies {
    api("cz.koto:android-keystore-compat:2.0.1") {
        exclude group: 'com.android.support'
    }
    api("cz.koto:android-keystore-compat-base:2.0.1")
    api("cz.koto:android-keystore-compat-19:2.0.1")
    api("cz.koto:android-keystore-compat-21:2.0.1")
    api("cz.koto:android-keystore-compat-23:2.0.1")
    implementation('com.scottyab:rootbeer-lib:0.0.6') {
        exclude group: 'com.android.support'
    }
}

Fix this ugly installation requirement to simplify gradle definition

kotoMJ commented 6 years ago

Will try to reduce need for dependency definition this way: https://android.jlelse.eu/releasing-multi-module-android-library-in-gradle-7286cd667b4b

kotoMJ commented 5 years ago

This is fixed in https://github.com/kotoMJ/security-showcase-android/tree/developV3

kotoMJ commented 5 years ago 
dependencies {
        api("cz.kotox:android-keystore-compat-kplus:${versions.keystore_compat}")
}