search

kotoMJ / security-showcase-android

Sample application pointing some security related practices on Android device.
130 stars 11 forks source link

Prevent KeyNotValidException for some Huawei devices #37

Closed yankauskas closed 5 years ago

yankauskas commented 5 years ago

There is an issue with some Huawei devices with KeyNotValidException (which is apparently related to incorrect work with TimeZones)

We have that bug on few our devices and it's hard to reproduce them. So I suggest to make a slight correction of key start date to prevent that crash event in theory.

Here you can find discussion about that bug

https://github.com/iamMehedi/Secured-Preference-Store/issues/15

kotoMJ commented 5 years ago

Ok @yankauskas if solution you provided helps, thx. for that catch. I have been working on new app code besides the library and will patch the library with this change. I will also introduce 3th version of the library including androidX and biometricprompt (as part of EmPlus package). This version of the library will have it's own package set (with new package name) and thus will be separated for optional upgrade to v3.

Have you been using version 1.x or version 2.x on your project? Just to know if I should patch just version 2.x or also version 1.x. Thx.

yankauskas commented 5 years ago

Hi! Thank you for quick response! We're using 2.0.1 on our project. Thanks for sharing your plans, we're waiting for next versions and we appreciate your work. Your library helps us a lot.

Bye for now :)

On Tue, Apr 9, 2019 at 10:07 PM Michal notifications@github.com wrote:

Ok @yankauskas https://github.com/yankauskas if solution you provided helps, thx. for that catch. I have been working on new app code besides the library and will patch the library with this change. I will also introduce 3th version of the library including androidX and biometricprompt (as part of EmPlus package). This version of the library will have it's own package set (with new package name) and thus will be separated for optional upgrade to v3.

Have you been using version 1.x or version 2.x on your project? Just to know if I should patch just version 2.x or also version 1.x. Thx.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kotomisak/security-showcase-android/pull/37#issuecomment-481395109, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPe1YXMCnM27BjYU2WDvTOInKUOnSABks5vfOUGgaJpZM4ckSFa .

-- Best regards, Yankauskas Viktor

v.yankauskas@gmail.com +380 (68) 8079774