search

kotoMJ / security-showcase-android

Sample application pointing some security related practices on Android device.
130 stars 11 forks source link

Feature/version 3 #43

Closed kotoMJ closed 5 years ago

mj-androidBot commented 5 years ago
6 Errors
:no_entry_sign: android-keystore-compat-21/src/main/kotlin/cz/koto/keystorecompat21/compat/KeystoreCompatL.kt#L63 - RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:no_entry_sign: android-keystore-compat-23/src/main/kotlin/cz/koto/keystorecompat23/compat/KeystoreCompatM.kt#L85 - RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:no_entry_sign: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/KeystoreCompatBase.kt#L269 - RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:no_entry_sign: android-keystore-compat-elplus/src/main/kotlin/cz/koto/keystorecompat/elplus/compat/KeystoreCompatImpl.kt#L16 - RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:no_entry_sign: android-keystore-compat-emplus/src/main/kotlin/cz/koto/keystorecompat/emplus/compat/KeystoreCompatImpl.kt#L13 - RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:no_entry_sign: android-keystore-compat/src/main/kotlin/cz/koto/keystorecompat/compat/KeystoreCompatImpl.kt#L19 - RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
25 Warnings
:warning: Big PR
:warning: /home/travis/.gradle/caches/transforms-2/files-2.1/6967f317f84467eb66b6fcefc6b4525c/timber-4.7.1/jars/lint.jar#L0 - Lint found an issue registry (timber.lint.TimberIssueRegistry) which is older than the current API level; these checks may not work correctly.

Recompile the checks against the latest version. Custom check API version is 1 (3.1), current lint API level is 5 (3.5+)
:warning: /home/travis/.gradle/caches/transforms-2/files-2.1/9d69e11bf6106ad3a07a815415899bc1/jetified-timber-4.7.1/jars/lint.jar#L0 - Lint found an issue registry (timber.lint.TimberIssueRegistry) which is older than the current API level; these checks may not work correctly.

Recompile the checks against the latest version. Custom check API version is 1 (3.1), current lint API level is 5 (3.5+)
:warning: android-keystore-compat-19/src/main/kotlin/cz/koto/keystorecompat19/SecurityDeviceAdmin.kt#L16 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-21/src/main/kotlin/cz/koto/keystorecompat21/compat/KeystoreCompatL.kt#L61 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-23/src/main/kotlin/cz/koto/keystorecompat23/compat/KeystoreCompatM.kt#L75 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-23/src/main/kotlin/cz/koto/keystorecompat23/crypto/KeystoreCryptoM.kt#L30 - Too many throw statements in the function encryptAES. The maximum number of allowed throw statements is 2.
:warning: android-keystore-compat-23/src/main/kotlin/cz/koto/keystorecompat23/crypto/KeystoreCryptoM.kt#L77 - The function decryptAES appears to be too complex.
:warning: android-keystore-compat-23/src/main/kotlin/cz/koto/keystorecompat23/crypto/KeystoreCryptoM.kt#L80 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/KeystoreCompatBase.kt#L34 - The function isDeviceRooted appears to be too complex.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/KeystoreCompatBase.kt#L84 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/KeystoreCompatBase.kt#L115 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/KeystoreCompatBase.kt#L184 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/compat/KeystoreCompatFacade.kt#L30 - The function loadSecret has too many parameters. The current threshold is set to 6.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/compat/KeystoreCompatFacade.kt#L39 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/crypto/KeystoreCryptoK.kt#L62 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/crypto/KeystoreCryptoK.kt#L70 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/hash/KeystoreHash.kt#L35 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/hash/KeystoreHash.kt#L59 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/utility/PrefDelegate.kt#L52 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/utility/PrefDelegate.kt#L66 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/utility/PrefDelegate.kt#L80 - Line detected that is longer than the defined maximum line length in the code style.
:warning: android-keystore-compat-base/src/main/kotlin/cz/koto/keystorecompat/base/utility/PrefDelegate.kt#L87 - Line detected that is longer than the defined maximum line length in the code style.
:warning: module-login/build/generated/source/navigation-args/dev/debug/cz/kotox/securityshowcase/login/ui/biometric/LoginBiometricFragmentArgs.kt#L20 - Object property names should match the pattern: [A-Za-z][_A-Za-z0-9]*
:warning: module-login/build/generated/source/navigation-args/dev/debug/cz/kotox/securityshowcase/login/ui/biometric/LoginBiometricFragmentArgs.kt#L24 - Line detected that is longer than the defined maximum line length in the code style.

Generated by :no_entry_sign: Danger