💥 Changes signature of `NotBlankString.Companion.create*` functions

kotools / types

Explicit types for Kotlin Multiplatform.

https://types.kotools.org

MIT License

90 stars 6 forks source link

💥 Changes signature of `NotBlankString.Companion.create*` functions #626

Closed augustomtt closed 8 months ago

augustomtt commented 8 months ago

Close #541.

Following the guidelines of issue #541, accepting a nullable object may be confusing for users:

Updated the signatures of the NotBlankString.Companion.create() and NotBlankString.Companion.createOrNull()
Tests related to the function invocation using passing a 'null' argument seem irrelevant now and are being deleted, however this may need further review by the repository maintainers, please keep an eye on this!
API Binaries update wasn't required

LVMVRQUXL commented 8 months ago

Thank you for your first contribution @augustomtt! 🥳 I will review it and may update it very soon. 😁 If you want to keep up with contributing to Kotools Types, you might be interested in the issue #618 for the next release. 👀

augustomtt commented 8 months ago

Thanks @LVMVRQUXL ! 🥳 I just noticed my commits were not signed, ping me if you need any further actions by me!

LVMVRQUXL commented 8 months ago

No worries about that, I am signing them before merging your changes @augustomtt. 😁

LVMVRQUXL commented 8 months ago

Successfully merged @augustomtt! 🎉 Thank you again for contributing. 🙏 Feel free to tackle another issue, I will be happy to review your quality work. 😁