kotools / types

Explicit types for Kotlin Multiplatform.
https://types.kotools.org
MIT License
90 stars 6 forks source link

🔥 Removal of `kotools.types.web.EmailAddress` type #639

Closed LVMVRQUXL closed 5 months ago

LVMVRQUXL commented 7 months ago

📝 Description

After deprecating it in #635, we want to remove the EmailAddress type from the kotools.types.web package.

✅ Checklist

MartiPresa commented 6 months ago

Hi, can i work on this issue? Thanks

LVMVRQUXL commented 6 months ago

Hello @MartiPresa, sure! Check our contributing guidelines for tackling this issue, and feel free to ask for help here or in discussions if needed. Thank you for considering to contribute. 🙏

MartiPresa commented 6 months ago

Hi, should i keep the index and only the index from kotools.types.web? Thanks, and sorry for the inconvenience.

LVMVRQUXL commented 6 months ago

Hello @MartiPresa, what do you mean about "the index and only the index from kotools.types.web"?

MartiPresa commented 6 months ago

I mean do i have to remove the entire -email-address file from kotools.types.web?

LVMVRQUXL commented 6 months ago

No @MartiPresa, only remove the source file implementing the EmailAddress type from the kotools.types.web package and its tests. This issue is not related to documentation but source declaration (that's why this issue doesn't have the documentation label). Documentation will be updated automatically after implementing this issue.