search

kottans-frontend-2018 / assignments_yevhenorlov

0 stars 0 forks source link

Task 12 #1

Closed yevhenorlov closed 6 years ago

yevhenorlov commented 6 years ago

🍿 demo

📝 source

Thanks in advance!

OleksiyRudenko commented 6 years ago

Great job!

This may come from css grid support specifics, but here is what I see in Chrome 63.0.3239.84 (64-bit, Windows 10): the rendered content is a bit wider than the port view.

sshot-180128-yo

Setting header { width: 100%; } (instead of 100vw) seems to fix the issue.

yevhenorlov commented 6 years ago

Thanks for your comments!

@viktor-yakubiv, I've fixed the BEM issue and removed commented code, and I'll keep in mind your tip about datetime attribute for the next stage of the task - seems pointless to change it now, before there's any application logic in place. Appreciate your feedback 👍

@OleksiyRudenko, good catch. However, looks like there's an irritating issue with 100% width of the content on MacOS - when the scrollbar gets transparent, this silly gap appears:

screen shot 2018-01-29 at 10 18 34 am

So I've decided to keep the width: 100vwand simply increase the padding from 10px to 20px, should work ok now. Thanks!