kottans / frontend-2019-p2p

Repo for students' homework p2p reviews
31 stars 44 forks source link

Add basic code review guidelines #1

Closed AMashoshyna closed 5 years ago

OleksiyRudenko commented 5 years ago

@AMashoshyna A suggestion for your consideration on a section to add.


Check 2 or 3 random PRs from the peer repo as reference examples of code review. Take a note of what mentors suggest to improve.

PRs with irrelevant commits can also be a source of ideas on how to support a student in issue resolution.

OleksiyRudenko commented 5 years ago

Not sure where to put these technical aspects of PR/code review: