kottans / frontend-2019-p2p

Repo for students' homework p2p reviews
31 stars 44 forks source link

Share code review guidelines #12

Open OleksiyRudenko opened 5 years ago

OleksiyRudenko commented 5 years ago

Both this repo and frontend-2019-homeworks need Code Review Guidelines (hereinafter the "CRG") while the latter are part of this repo only.

Possible options to resolve:

Things to consider:

o-msh commented 5 years ago

I can do it according to second options (move .md to kottans/frontend and add links). Also we can append some code review instructions in future. We have guidelines according to FE course except couple of common links in top of instructions. IMO while we doesn't have any different course yet. YAGNI. @OleksiyRudenko what do you think about it?

zonzujiro commented 5 years ago

kottans/frontend is a good option, as for me.

OleksiyRudenko commented 5 years ago

Looks like migration to kottans/frontend is the option. Let's see how things go with p2p model (will it survive, shall we be able to switch to p2p model completely) and if offline course students really need CRG when it is time to conduct peer CR within offline course. No hurry at the time being so we still can wait and see. Meanwhile other opinions may arrive here.

@o-msh , @zonzujiro , thank you for your input, guys!

OleksiyRudenko commented 5 years ago

As we have multiple courses and current course as of time of writing this is backend we may want the CRG be a part of something more global. Luckily we now have kottans/library

OleksiyRudenko commented 5 years ago

Keep #11 in mind if the CRG would migrate somewhere else.