search

kottans / frontend-2019-p2p

Repo for students' homework p2p reviews
31 stars 44 forks source link

Add xT0PERx folder with my home task popup-style #136

Closed DmitriyH01 closed 4 years ago

DmitriyH01 commented 4 years ago

Popup-style

Demo |
Code base|

The code is submitted in its own sub-directory and in a dedicated feature branch. Please, review.

DmitriyH01 commented 4 years ago

I made corrections according to your comments. Now works with the keyboard. Please check @A-Ostrovnyy.

A-Ostrovnyy commented 4 years ago

@xT0PERx Please commit and push your new version of popup, Current PR will be updated automatically

DmitriyH01 commented 4 years ago

@A-Ostrovnyy Everything is done. Thank you.

DmitriyH01 commented 4 years ago

@A-Ostrovnyy Need your help. Stopped working: focus on my icons inside popup

A-Ostrovnyy commented 4 years ago

@xT0PERx what's the issue with a focus on icons inside the popup? Tips: It can be more productive if you describe a problem in the first message, and I or another reviewer can help you in the next replay.)

DmitriyH01 commented 4 years ago

Please check @A-Ostrovnyy

A-Ostrovnyy commented 4 years ago

In the future, after pushing your local changes, click button Re-request review. image