search

kottans / frontend-2019-p2p

Repo for students' homework p2p reviews
31 stars 44 forks source link

memory pair game #198

Closed DaniaB24 closed 2 years ago

DaniaB24 commented 2 years ago

memory pair game

Demo | Code base

The code is submitted in its own sub-directory and in a dedicated feature branch. Please, review.

OleksiyRudenko commented 2 years ago

Please keep only files required for the code review (i.e. codebase part that was authored by you). See section B123 of submission guidelines. This helps reviewers jump straight to their job and makes their life easier.

DaniaB24 commented 2 years ago

Please keep only files required for the code review (i.e. codebase part that was authored by you). See section B123 of submission guidelines. This helps reviewers jump straight to their job and makes their life easier.

Hi^ sorry, okey I will remove)

OleksiyRudenko commented 2 years ago

Quite unexpected UX, esp. closer to the end of game. Also doesn't reshuffle cards for the next game. Record_2022_08_17_14_37_34_731-xs

DaniaB24 commented 2 years ago

Quite unexpected UX, esp. closer to the end of game. Also doesn't reshuffle cards for the next game. Record_2022_08_17_14_37_34_731-xs

okey, I will do it^ thanks for the review <3

OleksiyRudenko commented 2 years ago

Looks visually nice. How about posting a link in the students' chat and collecting user feedback?

DaniaB24 commented 2 years ago

Looks visually nice. How about posting a link in the students' chat and collecting user feedback?

okey, thanks a lot

OleksiyRudenko commented 2 years ago

This PR contains code from different tasks. Need to fix this

DaniaB24 commented 2 years ago

This PR contains code from different tasks. Need to fix this

yeah... I did it

OleksiyRudenko commented 2 years ago

Which files do we review?

image

DaniaB24 commented 2 years ago

Which files do we review?

image

@OleksiyRudenko re-review pls:) i think now everything is clear^

DaniaB24 commented 2 years ago

@OleksiyRudenko

DaniaB24 commented 2 years ago

@OleksiyRudenko re-review please) thank you a lot

DaniaB24 commented 2 years ago

@OleksiyRudenko

lysenko-sergey-developer commented 2 years ago

@DaniaB24 Good work!👍

DaniaB24 commented 2 years ago

@DaniaB24 Good work!👍

thank you a lot for review 🤝🤗 I will do it🫡

DaniaB24 commented 2 years ago

@lysenko-sergey-developer @OleksiyRudenko friendly reminder

DaniaB24 commented 2 years ago

@OleksiyRudenko @lysenko-sergey-developer thanks a lot<333

OleksiyRudenko commented 2 years ago

@DaniaB24 looks like you are missing only submission for OOP Exercise to have the full house of tasks.

DaniaB24 commented 2 years ago

@DaniaB24 looks like you are missing only submission for OOP Exercise to have the full house of tasks.

https://github.com/kottans/frontend-2022-homeworks/pull/172 it seems to be here

OleksiyRudenko commented 2 years ago

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

DaniaB24 commented 2 years ago

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

image but there is a code for oop 🤦‍♂️

DaniaB24 commented 2 years ago

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

image but there is a code for oop 🤦‍♂️

sorry, my bad