Add CONTRIBUTING.md - Githubissues

kottans / frontend

:octocat: Kottans frontend course 🎓

https://kottans.org/frontend/

MIT License

1.23k stars 361 forks source link

Add CONTRIBUTING.md #108

Closed OleksiyRudenko closed 6 years ago

suchov commented 6 years ago

a short description would be great If you mean to add the explanation how to contribute - I think it could go to README.md as a section

OleksiyRudenko commented 6 years ago

I shall suggest the content and let's then decide on the appropriate place for it.

OleksiyRudenko commented 6 years ago

Next steps (when github is back to us again :) ):

Add https://github.com/leonardomso/33-js-concepts "pr's welcome" label as per suggestion
Add link to http://makeapullrequest.com/
Add link to subset of https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github

cidre commented 6 years ago

Good work! :+1: Sorry, may I point out some suggestions without PR? :) 1) Please, feel free adding any comments. -> Please, feel free to add any comments. 2) It's important that commits be atomic to keep the history clean. -> It's important that commits are atomic to keep the history clean. 3) Below is a short guide on squashing commits into a clean history. -> Listed below is a short guide on squashing commits into a clean history.

OleksiyRudenko commented 6 years ago

Thank you!

And thank you for your suggestions. Well taken into consideration. However, I would say the squashing guide here lists some steps rather than gets listed [among others]. -ing is pretty OK here. Like feel free inquiring me.