search

kottans / frontend

:octocat: Kottans frontend course 🎓
https://kottans.org/frontend/
MIT License
1.22k stars 361 forks source link

Task friends app #133

Closed IgorKurkov closed 5 years ago

IgorKurkov commented 5 years ago

@OleksiyRudenko @yevhenorlov @zonzujiro @AMashoshyna folks :)

OleksiyRudenko commented 5 years ago

Looks like it interferes with #107 (Task 3: Add HTML...) When #107 is finally merged interfering commits must go. I would wait for this, or try to limit down the scope of this PR to commit cf1264d only.

zonzujiro commented 5 years ago

You have some problems with commits :)

IgorKurkov commented 5 years ago

Folks:) Can you check some bugs or add some improves if you want? I think description can be better but I have no idea

yevhenorlov commented 5 years ago

@IgorKurkov I think tasks/html-css-intro.md we can merge as is. Can you please submit it as a separate PR? Thanks

suchov commented 5 years ago

hmmm @zonzujiro haven't approved it? @OleksiyRudenko

OleksiyRudenko commented 5 years ago

@zonzujiro should we reopen this pr?