search

kottans / frontend

:octocat: Kottans frontend course 🎓
https://kottans.org/frontend/
MIT License
1.22k stars 361 forks source link

Example of task with p2p and regular course homeworks repos #243

Closed Oodmincheg closed 5 years ago

Oodmincheg commented 5 years ago

Add two links for different roads, And add #p2p-pr-done chat message. Links follow to my repos now, cause changes in anohter repositories hasn't approven yet.

Oodmincheg commented 5 years ago

prizivayu @OleksiyRudenko!

zonzujiro commented 5 years ago

So, the general structure must be:

Both repo's, frontend-2019-homeworks and frontend-2019-p2p must have two files each - contributing.md and readme.md.

readme.md must contain a general description of how task must be submitted - #done or #p2p-done accordingly, chats, etc. This part can be taken from several sources - text from each of task, readme of original frontend-2019-homeworks repo. contributing.md describes how to create a PR and obtain review. This stuff can be created also from readme of homework-2019 repo and from each task.

Both these files can be created using two sources - text from each of task and readme of original frontend-2019-homeworks repo.

In such a way student can open one of repo - p2p or online-course, and see readme with a general description of how to submit a task. This description should have a link to local contributing.md.

OleksiyRudenko commented 5 years ago

@zonzujiro @Oodmincheg Any suggestions on how do we link this with #236?

How about merging this and fixing other tasks appropriately, and implement changes as per #236 as the next iteration?

Oodmincheg commented 5 years ago

Any suggestions on how do we link this with #236?

@OleksiyRudenko Are #236 and code-review-guidlines different things? There is link into codereview section of contributing md of p2p-homeworks to code-review-guidlines.

OleksiyRudenko commented 5 years ago

@Oodmincheg I believe #236 is a suggestion to generalize all repeating instructions where and how to PR tasks into a dedicated file. Like making a library function in its own file (module) to refer to whenever it is needed and if any changes required those to be done in this dedicated file.

This might be a next iteration of instructions normalization.

Let's keep it for later times.