search

kottans / frontend

:octocat: Kottans frontend course 🎓
https://kottans.org/frontend/
MIT License
1.22k stars 361 forks source link

Add an aditional article to rwd task #320

Closed ORybka closed 3 years ago

ORybka commented 3 years ago

Please, consider adding this short article. The part about different types of pixels was pretty difficult to understand but this article helped me a lot.

ORybka commented 3 years ago

@OleksiyRudenko I still have problems with PRs :( I thought in this way I will remove the file only for the review, not for the repo

OleksiyRudenko commented 3 years ago

For the record: This PR resolves #315

OleksiyRudenko commented 3 years ago

@OleksiyRudenko I still have problems with PRs :( I thought in this way I will remove the file only for the review, not for the repo

In homeworks we ask not to add (rather than remove) files that are not required for review. Whatever is commited as deletion gets deleted from the repo.

No worries. That's why review is required. Just revert your last commit to undo file deletion.

ORybka commented 3 years ago

@OleksiyRudenko done :)

OleksiyRudenko commented 3 years ago

Oh, I see now. This PR also contains changes from #319

Not a big problem. However it is important to understand why this happened. That happened because you created a branch for this PR not from master (or main) but from the branch you've created for #319

image

Although this is not a big issue in this particular case (luckily). But you may want to learn how to fix this type of problems. Do you want to learn how to fix it?

OleksiyRudenko commented 3 years ago

For the record: this PR interferes with #319 (contains a commit from #319).

ORybka commented 3 years ago

@OleksiyRudenko Yes! Please! I have no idea, how to solve it and I see the mistake