search

kottans / frontend

:octocat: Kottans frontend course 🎓
https://kottans.org/frontend/
MIT License
1.23k stars 361 forks source link

Translation on Ukrainian #361

Closed yaripey closed 2 years ago

yaripey commented 2 years ago

Work in progress по перекладанню рідмішек.

suchov commented 2 years ago

Make it as draft for now. Pls switch it to “Ready for review” when you’ll be ready.

suchov commented 2 years ago

@artem-trubin what do you think about leaving the README.md as it'll show up as a main file in the repo... https://stackoverflow.com/questions/69188881/rename-readme-md-to-custom-name-and-use-as-a-project-description As I understood it'll not show up as like now otherwise or I am too quick?

yaripey commented 2 years ago

@suchov

My bad, I've named the commit wrong. In this commit I'm actually deleting readme-old.md, a temporary file that I used for translation purposes, that was not inteded to be put in the repo in the first place.

A-Ostrovnyy commented 2 years ago

I think the approach with one PR for one translated file will be much easier in parallel translation (reduce time on merging and resolving conflicts). What do you think about that?

suchov commented 2 years ago

I would agree with @A-Ostrovnyy let's maybe merge what we have? @artem-trubin what do you think? so we can work case by case after that and all the team can send PR's with fixes, create issues...

yaripey commented 2 years ago

I'll ask Hanna is it fine by her to merge this, since she's also done a lot of work.

The only thing is, there are some place that I marked as **TBD** where some information should go that is currently unknown. When the course starts, for instance. Is it okay to merge like this?

A-Ostrovnyy commented 2 years ago

@artem-trubin it's ok. I prefer to use TODO: instead of ***TBD***, most IDEs or code editors highlight that and it helps to fix it later.

suchov commented 2 years ago

And even that is on - we can change TBD to TODO: rather quickly - with 1 PR ;)

HannaSyn commented 2 years ago

Ready to merge

suchov commented 2 years ago

@HannaSyn so we can ask @A-Ostrovnyy to check it out?

HannaSyn commented 2 years ago

Yes, @A-Ostrovnyy please review

A-Ostrovnyy commented 2 years ago

@artem-trubin @suchov @HannaSyn Your turn to review changes)

HannaSyn commented 2 years ago

Why HTAQ.md wasn't translated? I think it should be @artem-trubin @suchov @A-Ostrovnyy

yaripey commented 2 years ago

@HannaSyn I was sure I did it, maybe missed somehow. I'll do it.

suchov commented 2 years ago

@artem-trubin sen a PR ;) thanks a ton! Here we go, our first PR 🚀