kottans / frontend

:octocat: Kottans frontend course 🎓
https://kottans.org/frontend/
MIT License
1.23k stars 361 forks source link

Fixed wrong render of the chat links #399

Closed rashevskyv closed 2 years ago

rashevskyv commented 2 years ago

Symbol | cause wrong render of the link like a table.

yaripey commented 2 years ago

Can you maybe provide a screenshot of what changed, because it seems like these slashes didn't change anything?

rashevskyv commented 2 years ago

On github preview page all fine on both versions, but since you block PR, I cannot see how it renders on the page itself. Maybe you should try to use some other symbol, or remove spaces, or use &nbsp instead of spaces.

rashevskyv commented 2 years ago

изображение Still rendered as table unfortunately You should get of the | symbol 😅

A-Ostrovnyy commented 2 years ago

Linux/Firefox

image

yaripey commented 2 years ago

@A-Ostrovnyy is this screenshot from Github Pages? The problem is that for some reason that table bug is present ONLY in GitHub Pages. Here

rashevskyv commented 2 years ago

It is rendered as table, so browser and OS should not be effected изображение

(win10x64 / ff)

yaripey commented 2 years ago

It is fixed now, after deployment! GJ.

P.S.: @rashevskyv thanks for awesome guides, you're basicaly a hero :D

A-Ostrovnyy commented 2 years ago

After merge looks much better @rashevskyv thanks image

rashevskyv commented 2 years ago

P.S.: @rashevskyv thanks for awesome guides, you're basicaly a hero :D

OFFTOP: You should check what awesome popup I put on the guides 😈

yaripey commented 2 years ago

Oh, I saw it, awesome popup indeed :D

You still have VK links though, are those publics alive?

rashevskyv commented 2 years ago

Public is alive, still a lot of Ukrainians are use vk. And I am glad to bring some discomfort to everyone who support war in that way)