koudelka / honeydew

Job Queue for Elixir. Clustered or Local. Straight BEAM. Optional Ecto. 💪🍈
MIT License
724 stars 59 forks source link

Fix bug in validate_args!/1 #85

Closed Schultzer closed 5 years ago

Schultzer commented 5 years ago

Hi @koudelka,

Thanks for creating honeydew, it's been my go to job queue for all my elixir projects.

I'm having one problem with setting up a global queue following the example in global.

    :ok = Honeydew.start_queue({:global, :my_queue}, queue: {Honeydew.Queue.Mnesia, [[node()], [disc_copies: nodes], []]})

This always fails because nodes_list/1 is trying to do Keyword.get/3 on a list.

Schultzer commented 5 years ago

I'm not sure this is the fix but when starting up validate_args/1 receive [[node()], [disc_copies: nodes], []] instead of [disc_copies: nodes]

koudelka commented 5 years ago

hey there @Schultzer, it looks like i've forgotten to update the docs in that section, sorry about that!

i've pushed a fix, mind trying it out? :)

Schultzer commented 5 years ago

Thanks, it works! ❤️

koudelka commented 5 years ago

No worries, Nomad looks awesome, btw! :)