koukibadr / Bottom-Picker

https://pub.dev/packages/bottom_picker
MIT License
32 stars 21 forks source link

issue on onSubmit in BottomPicker.time not working #80

Open Abdallah-Azb opened 10 months ago

Abdallah-Azb commented 10 months ago

in code should be like this your code onClick: () { if (widget.bottomPickerType ==BottomPickerType.simple) { widget.onSubmit?.call(selectedItemIndex); } else if (widget.bottomPickerType ==BottomPickerType.dateTime || widget.bottomPickerType == BottomPickerType.time ) { widget.onSubmit?.call(selectedDateTime); } else { widget.onSubmitPressed?.call( selectedFirstDateTime, selectedSecondDateTime, ); }

                    Navigator.pop(context);
                  },
the right code should be like this 

onClick: () { if (widget.bottomPickerType ==BottomPickerType.rangeDateTime) {

                       widget.onSubmitPressed?.call(
                        selectedFirstDateTime,
                        selectedSecondDateTime,);

                    } else {
                      widget.onSubmit?.call(selectedItemIndex);
                      }

                    Navigator.pop(context);
                  },
koukibadr commented 9 months ago

A new version has been published with the fix of this bug the new version 2.3.3 is available on pub.dev