koukibadr / Elegant-Notification

https://pub.dev/packages/elegant_notification
MIT License
46 stars 30 forks source link

Icons not proper in Arabic mode #84

Closed farooq023 closed 1 year ago

farooq023 commented 1 year ago

Screenshot_1683526465

The app I am building has localization of 2 languages, English & Arabic. Both of the icons in the notification are not aligned properly in Arabic mode. Kindly see the SS attached. This issue occurs only in Arabic mode, not in English mode.

shatanikmahanty commented 1 year ago

@farooq023 it is happening due to missing RTL support in the package. I have added the change in my latest PR.

farooq023 commented 1 year ago

I am not using RTL/LTR in my project anywhere. I am just localizing, which is itself doing the RTL/LTR. Will your solution work for me?

shatanikmahanty commented 1 year ago

Yeah, it will work for that case. i tested by just setting the language to arabic in supportedLocales

farooq023 commented 1 year ago

Alright, thanks a lot. Is your commit merged now? When can I update the package?

shatanikmahanty commented 1 year ago

Alright, thanks a lot. Is your commit merged now? When can I update the package?

You can update once the repo maintainer approves my changes, till then if you want you can use my fork link in pubspec for a fix

https://github.com/shatanikmahanty/Elegant-Notification/

farooq023 commented 1 year ago

I removed the previous package & added your fork link in pubspec file, and the problem is still there.

shatanikmahanty commented 1 year ago

I removed the previous package & added your fork link in pubspec file, and the problem is still there.

Can you show me the code you are using specifying localisation and the elegant notification?

shatanikmahanty commented 1 year ago

@farooq023 are you by any chance using the main branch from my repo? The code is in rtl branch.

farooq023 commented 1 year ago
elegant_noti

Please view the SS attached.

shatanikmahanty commented 1 year ago
elegant_noti

Please view the SS attached.

Please add below url the branch name.

ref: rtl

PS: I have also merged the branch into my Forks main, so your previous import should also work

farooq023 commented 1 year ago

Thanks a lot, I added the branch name & it's solved now. Alright, I will remove the branch name. I can use the package from your git link until the package is updated in pub.dev.

shatanikmahanty commented 1 year ago

Thanks a lot, I added the branch name & it's solved now. Alright, I will remove the branch name. I can use the package from your git link until the package is updated in pub.dev.

You're welcome. Happy to help 🙌

koukibadr commented 1 year ago

Thanks @farooq023 for filling the issue @shatanikmahanty amazing job ! the new version is available in pub.dev (1.10.0)

shatanikmahanty commented 1 year ago

Thanks @farooq023 for filling the issue @shatanikmahanty amazing job ! the new version is available in pub.dev (1.10.0)

Thanks @koukibadr. Happy to contribute to this awesome package ✨